On Sat, Jan 17, 2009 at 12:03 AM, Brad Nicholes <bnicho...@novell.com> wrote: > I have updated the bug #223 with a consolidated patch. Please review and > provide feedback for backporting to the 3.1 branch. Once we get the patched > reviewed and backported to 3.1, let's move forward with the release of 3.1.2. > > +1 backport from me
If I'm looking at the right one (http://bugzilla.ganglia.info/cgi-bin/bugzilla/attachment.cgi?id=187&action=view) the comment should be removed since the +1 is there: + /* +1 not needed as q-p is already accounting for that */ + element = malloc(len + 1); other than that looks good to me. Two things: 1) How has this been tested? I did some myself and got to wonder how you guys did it, do you have any standardized approach? 2) you mention backports to 3.1 and then move on to 3.1.2, what about 3.0? Some of us (quite a few?) are still running 3.0 and afaik kostas already applied the patch to that branch and ran some tests (and so did I - and server.c hasn't changed for a long time so it should be indeed a safe operation) thanks -- "Behind every great man there's a great backpack" - B. ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
