On Sun, Jan 18, 2009 at 11:22:27AM +0800, Spike Spiegel wrote: > > the comment should be removed since the +1 is there: > > + /* +1 not needed as q-p is already accounting for that */ > + element = malloc(len + 1);
Committed revision 1950 > other than that looks good to me. could you check the "simplified" one?, this problem was introduced in 2003 and therefore affects all versions of ganglia since then (including 2.5.7 which is not supported anymore and that will need to be patched by the users of it which include Debian/Ubuntu, Novell/OpenSuSE and probably others). > Two things: > 1) How has this been tested? I did some myself and got to wonder how > you guys did it, do you have any standardized approach? sadly there is no test suite associated with ganglia code and therefore there is no "standardized" approach other than applying the patch and banging the resulting binary to see if it works reliably. > 2) you mention backports to 3.1 and then move on to 3.1.2, what about > 3.0? Some of us (quite a few?) are still running 3.0 and afaik kostas > already applied the patch to that branch and ran some tests (and so > did I - and server.c hasn't changed for a long time so it should be > indeed a safe operation) it will be included in 3.0.8 as well. Carlo ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
