Vampire commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2167574459
##########
doc/manual/src/docs/asciidoc/080-javascript.adoc:
##########
@@ -291,24 +293,24 @@
include::{cm-snippets-dir}/geb/js/AlertAndConfirmSupport.groovy[tag=alert,indent
The first method, `withAlert()`, is used to verify actions that will produce
an alert dialog.
This method returns the alert message.
-Given the following HTML…
+Given the following HTML...
[source,html]
----
include::{snippets-dir}/javascript/AlertSpec.groovy[tag=alert_html,indent=0]
----
-The `withAlert()` method is used like so…
+The `withAlert()` method is used like so...
[source,groovy]
----
include::{snippets-dir}/javascript/AlertSpec.groovy[tag=alert,indent=0]
----
-If an alert dialog is not raised by the given “actions” closure, an
`AssertionError` will be thrown.
+If an alert dialog is not raised by the given "`actions`" closure, an
`AssertionError` will be thrown.
Review Comment:
Yeah, before there were typographic quotes directly used like also the
ellipsis characters I replaced.
I guess this is a left-over from previously having Markdown used, not
AsciiDoc.
In Markdown you had to use those characters directly.
In Asciidoc the idiomatic way is ``"``` for opening typographic quote,
```"`` for closing typographic quote and `...` for ellipsis and the processor
replaces them accordingly.
This makes it more **Ascii**Doc, easier readable in some tools and you also
cannot as easily use the wrong typographic quotes (start and end were swapped
in some cases).
There were indeed also some cases where there were quotes around
code-formatted phrase, there I indeed removed the quotes to only have the
code-format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
