Vampire commented on code in PR #277:
URL: https://github.com/apache/groovy-geb/pull/277#discussion_r2167602902


##########
doc/manual/src/docs/asciidoc/120-build-integrations.adoc:
##########
@@ -10,37 +10,88 @@ Using Geb with Gradle simply involves pulling in the 
appropriate dependencies, a
 
 Below is a valid Gradle `build.gradle` file for working with Geb for testing.
 
-[source,groovy,subs="attributes"]
+[tabs]
+====
+Kotlin::
++
+[source,kotlin,subs="+attributes"]
 ----
-apply plugin: "groovy"
+plugins {
+    groovy
+}
 
 repositories {
     mavenCentral()
 }
 
-ext {
-    gebVersion = "{geb-version}"
-    seleniumVersion = "{selenium-version}"
-}
+val gebVersion = "{geb-version}"
+val seleniumVersion = "{selenium-version}"
+
+testing {

Review Comment:
   That API did not change in the last 4 years as far as I remember, and it is 
what already is used below the covers of the `test` task, and it is **the** way 
to go if you want additional test types like functional tests or integration 
tests for which Geb most probably is usually used I'd say.
   
   If you really prefer I can of course switch this to the "old" syntax.
   But compared to the current state it at least works, the old code did not 
work anymore since 4 years, as the `compile` configuration and friends that 
were deprecated since many more years were finally removed in 7.0 and since 
then the examples did not work anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to