----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/748/#review1351 -----------------------------------------------------------
src/arch/mips/isa/decoder.isa <http://reviews.m5sim.org/r/748/#comment1805> I see, the instruction was defined in a non-intuitive way. Another way to write this (from the SEE MIPS RUN book is): Fr.sf - (Fs.sf * Ft.sf) for nmsub_s and -1 * (Fs.sf * Ft.sf + Fr.sf) for nmadd_s I agree w/your updates now. However, how did you find this error? Through inspection or running a benchmark? If the latter, we need to add that regression (or a similar one) to preserve that functionality. src/cpu/inorder/inorder_dyn_inst.cc <http://reviews.m5sim.org/r/748/#comment1806> Separate patch means add a new review request. Eventually, I'll have to commit your patches to the tree (w/your email as author), so it's best not to merge nonrelated changes. If you get "simulate() reached", that means your system likely deadlocked as there are no more events on the main event queue. Run w/the cpu progress interval on to help determine where the CPUs stops committing instructions. Also, post the locked_mem.hh patch if you want comments on what you are trying to do to resolve the problem. - Korey On 2011-06-21 02:16:53, Deyuan Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/748/ > ----------------------------------------------------------- > > (Updated 2011-06-21 02:16:53) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Make the newly gem5 support mips branch likely instruction again. > Fix 4 files: > src/arch/mips/isa/formats/branch.isa > src/cpu/inorder/inorder_dyn_inst.cc > src/cpu/inorder/resources/branch_predictor.cc > src/cpu/inorder/resources/fetch_seq_unit.cc > > > Diffs > ----- > > src/arch/mips/isa/decoder.isa 00766f5b8177 > src/arch/mips/isa/formats/branch.isa 00766f5b8177 > src/cpu/inorder/inorder_dyn_inst.cc 00766f5b8177 > src/cpu/inorder/resources/branch_predictor.cc 00766f5b8177 > src/cpu/inorder/resources/fetch_seq_unit.cc 00766f5b8177 > > Diff: http://reviews.m5sim.org/r/748/diff > > > Testing > ------- > > Tested. > > > Thanks, > > Deyuan > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
