----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/897/#review1628 -----------------------------------------------------------
You shouldn't change any of the places where ldstl or stul are used. They should have the properties they need implicitly, and regular loads/stores should take a parameter to set those optionally. - Gabe On 2011-10-30 22:26:03, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/897/ > ----------------------------------------------------------- > > (Updated 2011-10-30 22:26:03) > > > Review request for Default. > > > Summary > ------- > > X86 ISA: Change definitions of locked instructions > This patch is for changing the defintion of locked instructions. These > should behave as memory barriers and should be executed in a non speculative > fashion. > > > Diffs > ----- > > src/arch/x86/isa/insts/general_purpose/arithmetic/add_and_subtract.py > dd77c8d0a93e > > src/arch/x86/isa/insts/general_purpose/arithmetic/increment_and_decrement.py > dd77c8d0a93e > src/arch/x86/isa/insts/general_purpose/compare_and_test/bit_test.py > dd77c8d0a93e > src/arch/x86/isa/insts/general_purpose/data_transfer/xchg.py dd77c8d0a93e > src/arch/x86/isa/insts/general_purpose/input_output/general_io.py > dd77c8d0a93e > src/arch/x86/isa/insts/general_purpose/input_output/string_io.py > dd77c8d0a93e > src/arch/x86/isa/insts/general_purpose/logical.py dd77c8d0a93e > src/arch/x86/isa/insts/general_purpose/semaphores.py dd77c8d0a93e > src/arch/x86/isa/microops/ldstop.isa dd77c8d0a93e > > Diff: http://reviews.m5sim.org/r/897/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
