> On Jan. 26, 2012, 6:14 a.m., Andreas Hansson wrote: > > src/mem/cache/prefetch/base.hh, line 104 > > <http://reviews.gem5.org/r/1011/diff/1/?file=21459#file21459line104> > > > > Is setCache necessary or can we do this in the constructor? > > Ali Saidi wrote: > how could it be done in the constructor? cache has a pointer to the > prefetcher, not the other way around.
I was more thinking along the lines of knowing who the parent is, similar to previous discussions. There is clearly an object hierarchy here and the cache is the parent of the prefetcher. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1011/#review1996 ----------------------------------------------------------- On Jan. 26, 2012, 4:30 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1011/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2012, 4:30 a.m.) > > > Review request for Default. > > > Description > ------- > > prefetcher: Make prefetcher a sim object instead of it being a parameter on > cache > > > Diffs > ----- > > src/mem/cache/BaseCache.py 78b08f92c290 > src/mem/cache/builder.cc 78b08f92c290 > src/mem/cache/cache.hh 78b08f92c290 > src/mem/cache/cache_impl.hh 78b08f92c290 > src/mem/cache/prefetch/Prefetcher.py PRE-CREATION > src/mem/cache/prefetch/SConscript 78b08f92c290 > src/mem/cache/prefetch/base.hh 78b08f92c290 > src/mem/cache/prefetch/base.cc 78b08f92c290 > src/mem/cache/prefetch/ghb.hh 78b08f92c290 > src/mem/cache/prefetch/ghb.cc 78b08f92c290 > src/mem/cache/prefetch/stride.hh 78b08f92c290 > src/mem/cache/prefetch/stride.cc 78b08f92c290 > src/mem/cache/prefetch/tagged.hh 78b08f92c290 > src/mem/cache/prefetch/tagged.cc 78b08f92c290 > > Diff: http://reviews.gem5.org/r/1011/diff/diff > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
