No, I did not. I just manually uploaded my patch through review-board's interface. Let me look into that and give it a try. Thanks, Marc
On Mon, Mar 5, 2012 at 6:19 PM, Nilay Vaish <[email protected]> wrote: > Did you use the postreview extension of hg? > > -- > Nilay > > > On Mon, 5 Mar 2012, Marc Orr wrote: > >> Hi All, >> >> I just tried to submit my first patch. Unfortunately, it appears that I >> did >> not do it correctly. When I click "view diff", I discover that the patch >> does not apply cleanly. >> >> I cloned the public repository and tried applying the patch that I think I >> uploaded and it seems to apply fine. Any suggestions or tips would be >> appreciated. >> >> Thanks! >> Marc >> >> On Mon, Mar 5, 2012 at 5:48 PM, Marc Orr <[email protected]> wrote: >> >>> This is an automatically generated e-mail. To reply, visit: >>> http://reviews.gem5.org/r/1080/ >>> Review request for Default. >>> By Marc Orr. >>> Description >>> >>> build scripts: Made minor modifications to reduce build overhead time. >>> >>> 1. --implicit-cache behavior is default. >>> 2. makeEnv in src/SConscript is conditionally called. >>> 3. decider set to MD5-timestamp >>> 4. NO_HTML build option changed to SLICC_HTML (defaults to False) >>> >>> Testing >>> >>> Ran ./util/regress. Seemed to behave as expected. >>> changeset: 8855:d6e90b1998c3 >>> >>> Diffs >>> >>> - SConstruct (d6e90b1998c3046a69ca29e89453ce4463cfb5f5) >>> - src/SConscript (d6e90b1998c3046a69ca29e89453ce4463cfb5f5) >>> - src/mem/protocol/SConscript >>> (d6e90b1998c3046a69ca29e89453ce4463cfb5f5) >>> - src/mem/protocol/SConsopts (d6e90b1998c3046a69ca29e89453ce4463cfb5f5) >>> >>> View Diff <http://reviews.gem5.org/r/1080/diff/> >>> >> _______________________________________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/gem5-dev >> > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
