----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1081/#review2274 -----------------------------------------------------------
Hi Marc. Looks great, but I too have a concern like Gabe mentioned. Not so much in his usecase, but what happens if you try to build one of the unittest binaries or a regression test target (that implicitly depends on a binary)? Otherwise looks great. Thanks for all the effort. Ali - Ali Saidi On March 5, 2012, 7:21 p.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1081/ > ----------------------------------------------------------- > > (Updated March 5, 2012, 7:21 p.m.) > > > Review request for Default. > > > Description > ------- > > build scripts: Made minor modifications to reduce build overhead time. > > 1. --implicit-cache behavior is default. > 2. makeEnv in src/SConscript is conditionally called. > 3. decider set to MD5-timestamp > 4. NO_HTML build option changed to SLICC_HTML (defaults to False) > > Changeset 8880:76a0a9c986fe > --------------------------- > imported patch buildFaster > > > Diffs > ----- > > SConstruct 347fc850752ceaba43a975651340a49d8ac660e1 > src/SConscript 347fc850752ceaba43a975651340a49d8ac660e1 > src/mem/protocol/SConscript 347fc850752ceaba43a975651340a49d8ac660e1 > src/mem/protocol/SConsopts 347fc850752ceaba43a975651340a49d8ac660e1 > > Diff: http://reviews.gem5.org/r/1081/diff/ > > > Testing > ------- > > Ran ./util/regress. Seemed to behave as expected. > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
