Hi Marc, You're right on all counts. Typically since this is your first patch someone with commit access will just push the patch on your behalf... I'd be glad to do it, as would Brad I'm sure. Once you are so productive that we get annoyed pushing patches on your behalf then we'll give you direct commit access ;-).
Steve On Wed, Mar 7, 2012 at 8:40 AM, Marc Orr <[email protected]> wrote: > Great! Since this is my first patch, I will ask for a little guidance. > > My next steps as I understand it are: > 1. To incorporate the last pieces of feedback. > 2. Push the patch to the global repository. > 3. Mark the patch as submitted on review board. > > Is this correct? Or am I getting ahead of myself? > > Also, I believe that submitting the patch requires an ssh path (from > searching the lists). I'm not quite sure how to set this up. > > Thanks in advance. > > Marc > > On Tue, Mar 6, 2012 at 3:16 PM, Andreas Hansson <[email protected] > >wrote: > > > This is an automatically generated e-mail. To reply, visit: > > http://reviews.gem5.org/r/1081/ > > > > Ship it! > > > > Ship It! > > > > > > - Andreas > > > > On March 6th, 2012, 11:44 a.m., Marc Orr wrote: > > Review request for Default. > > By Marc Orr. > > > > *Updated March 6, 2012, 11:44 a.m.* > > Description > > > > Changeset 8880:a9d55a7a1449 > > --------------------------- > > imported patch buildFaster > > > > Testing > > > > Ran ./util/regress. Seemed to behave as expected. > > > > Diffs > > > > - SConstruct (347fc850752ceaba43a975651340a49d8ac660e1) > > - src/SConscript (347fc850752ceaba43a975651340a49d8ac660e1) > > - src/mem/protocol/SConscript > > (347fc850752ceaba43a975651340a49d8ac660e1) > > - src/mem/protocol/SConsopts > (347fc850752ceaba43a975651340a49d8ac660e1) > > > > View Diff <http://reviews.gem5.org/r/1081/diff/> > > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
