----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1081/#review2280 -----------------------------------------------------------
Ship it! Other than the extra blank line and making sure you get the right commit message (somehow you lost it in the update), this looks great to me. Thanks! src/SConscript <http://reviews.gem5.org/r/1081/#comment2702> Looks like you have a spurious blank line here. - Steve Reinhardt On March 6, 2012, 11:44 a.m., Marc Orr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1081/ > ----------------------------------------------------------- > > (Updated March 6, 2012, 11:44 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8880:a9d55a7a1449 > --------------------------- > imported patch buildFaster > > > Diffs > ----- > > SConstruct 347fc850752ceaba43a975651340a49d8ac660e1 > src/SConscript 347fc850752ceaba43a975651340a49d8ac660e1 > src/mem/protocol/SConscript 347fc850752ceaba43a975651340a49d8ac660e1 > src/mem/protocol/SConsopts 347fc850752ceaba43a975651340a49d8ac660e1 > > Diff: http://reviews.gem5.org/r/1081/diff/ > > > Testing > ------- > > Ran ./util/regress. Seemed to behave as expected. > > > Thanks, > > Marc Orr > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
