----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1143/#review2547 -----------------------------------------------------------
src/arch/x86/tlb.cc <http://reviews.gem5.org/r/1143/#comment2960> This should probably be if (size == 0) fatal("...") since this could be the result of user error (i.e., a poorly written config script) and not a program bug. src/base/trie.hh <http://reviews.gem5.org/r/1143/#comment2961> Looks like you got these comment changes in the wrong changeset. Of course, an easy fix is just to merge the changesets ;-). (Sorry, I just can't help it.) - Steve Reinhardt On April 14, 2012, 6:05 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1143/ > ----------------------------------------------------------- > > (Updated April 14, 2012, 6:05 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8952:f62d0aefe43f > --------------------------- > X86: Use the AddrTrie class to implement the TLB. > > This change also adjusts the TlbEntry class so that it stores the number of > address bits wide a page is rather than its size in bytes. In other words, > instead of storing 4K for a 4K page, it stores 12. 12 is easy to turn into 4K, > but it's a little harder going the other way. > > > Diffs > ----- > > src/arch/x86/pagetable.hh a6830d615eff > src/arch/x86/pagetable.cc a6830d615eff > src/arch/x86/pagetable_walker.hh a6830d615eff > src/arch/x86/pagetable_walker.cc a6830d615eff > src/arch/x86/tlb.hh a6830d615eff > src/arch/x86/tlb.cc a6830d615eff > src/arch/x86/vtophys.cc a6830d615eff > src/base/trie.hh PRE-CREATION > > Diff: http://reviews.gem5.org/r/1143/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
