> On Jan. 15, 2013, 5:23 a.m., Nilay Vaish wrote:
> > configs/common/CpuConfig.py, line 50
> > <http://reviews.gem5.org/r/1606/diff/1/?file=32924#file32924line50>
> >
> > Can this not be part of CPU meta data?
There were two reasons for the current design:
* The aliases were supposed to be a fall-back mechanism to provide backwards
compatibility for existing scripts and CPUs and as such I felt that they were a
part of the configuration script rather than the meta data.
* The current system allows a tuple to be used instead of a single target. In
that case, the first target that has been compiled is used. This was mainly
intended to be used for virtualized CPUs where the 'kvm' alias could point to
('KvmArmCPU', 'KvmX86CPU') and the first available CPU would be used. Storing
the alias as meta data would make this a bit trickier if you want to have a
well defined search order when resolving the alias.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1606/#review3848
-----------------------------------------------------------
On Jan. 7, 2013, 11:30 a.m., Ali Saidi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1606/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 11:30 a.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 9455:969ab2ed5cfa
> ---------------------------
> config: Cleanup CPU configuration
>
> The CPUs supported by the configuration scripts used to be
> hard-coded. This was not ideal for several reasons. For example, the
> configuration scripts depend on all CPU models even though only a
> subset might have been compiled.
>
> This changeset adds a new module to the configuration scripts that
> automatically discovers the available CPU models from the compiled
> SimObjects. As a nice bonus, the use of introspection allows us to
> automatically generate a list of available CPU models suitable for
> printing. This list is augmented with the Python doc string from the
> underlying class if available.
>
>
> Diffs
> -----
>
> configs/common/CpuConfig.py PRE-CREATION
> configs/common/Options.py 56610ab73040
> configs/common/Simulation.py 56610ab73040
>
> Diff: http://reviews.gem5.org/r/1606/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ali Saidi
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
