----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1621/#review3900 -----------------------------------------------------------
tests/test-progs/mwait/mwait.c <http://reviews.gem5.org/r/1621/#comment3771> This is not used anywhere. tests/test-progs/mwait/mwait.c <http://reviews.gem5.org/r/1621/#comment3772> It seems you are only using flags[0] and wait[0]. Why create space for 10? tests/test-progs/mwait/mwait.c <http://reviews.gem5.org/r/1621/#comment3770> Since the code is being copied from the linux kernel, would it not come under GPL? tests/test-progs/mwait/mwait.c <http://reviews.gem5.org/r/1621/#comment3774> How do you know this would run on a different cpu? - Nilay Vaish On Jan. 14, 2013, 9:33 a.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1621/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 9:33 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9467:84decd4c3a2d > --------------------------- > test: A test program for the new mwait implementation. > > This is a simple test program for the new mwait implemenation. It is uses > m5threads to create to threads of execution in syscall emulation mode that > interact using the mwait instruction. > > *Note* This patch was originally created by Marc Orr ([email protected]) > > > Diffs > ----- > > tests/test-progs/mwait/Makefile PRE-CREATION > tests/test-progs/mwait/mwait.c PRE-CREATION > tests/test-progs/mwait/pthread.o 794711cac18b0b5b47782675d45b886f2c31449c > > Diff: http://reviews.gem5.org/r/1621/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
