> On Jan. 25, 2013, 9:23 a.m., Nilay Vaish wrote: > >
Hi Nilay, Thanks for the comments! Marc > On Jan. 25, 2013, 9:23 a.m., Nilay Vaish wrote: > > tests/test-progs/mwait/mwait.c, line 10 > > <http://reviews.gem5.org/r/1621/diff/1/?file=33188#file33188line10> > > > > It seems you are only using flags[0] and wait[0]. Why create space for > > 10? To ensure that flags and wait don't sit in the same cache line. > On Jan. 25, 2013, 9:23 a.m., Nilay Vaish wrote: > > tests/test-progs/mwait/mwait.c, line 13 > > <http://reviews.gem5.org/r/1621/diff/1/?file=33188#file33188line13> > > > > Since the code is being copied from the linux kernel, would it not come > > under GPL? I changed the code to call mwait and monitor via gcc intrinsics in a new revision that I sent to Derek. > On Jan. 25, 2013, 9:23 a.m., Nilay Vaish wrote: > > tests/test-progs/mwait/mwait.c, line 66 > > <http://reviews.gem5.org/r/1621/diff/1/?file=33188#file33188line66> > > > > How do you know this would run on a different cpu? I've added code to make sure that thread 0 is schedueld on core 0 and thread 1 is scheduled on core 1 in a new revision that I sent to Derek. > On Jan. 25, 2013, 9:23 a.m., Nilay Vaish wrote: > > tests/test-progs/mwait/mwait.c, line 7 > > <http://reviews.gem5.org/r/1621/diff/1/?file=33188#file33188line7> > > > > This is not used anywhere. Fixed in a new revision that I sent Derek. - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1621/#review3900 ----------------------------------------------------------- On Jan. 14, 2013, 9:33 a.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1621/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2013, 9:33 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9467:84decd4c3a2d > --------------------------- > test: A test program for the new mwait implementation. > > This is a simple test program for the new mwait implemenation. It is uses > m5threads to create to threads of execution in syscall emulation mode that > interact using the mwait instruction. > > *Note* This patch was originally created by Marc Orr ([email protected]) > > > Diffs > ----- > > tests/test-progs/mwait/Makefile PRE-CREATION > tests/test-progs/mwait/mwait.c PRE-CREATION > tests/test-progs/mwait/pthread.o 794711cac18b0b5b47782675d45b886f2c31449c > > Diff: http://reviews.gem5.org/r/1621/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
