> On Feb. 8, 2013, 4:09 p.m., Nilay Vaish wrote: > > tests/test-progs/mwait/Makefile, line 17 > > <http://reviews.gem5.org/r/1621/diff/3/?file=33567#file33567line17> > > > > Are sure that pthread.o is available? > > Marc Orr wrote: > Well, it won't be available. This patch adds the object file to the repo. > I don't think this is a good precedent to set though. > > Maybe instead, I can add a README file that explains how to get > m5threads, and built the pthread.o file? How does this sound? do you have any > other suggestions?
Nilay, are you ok with a README file here? Once I have clear direction on this comment, I will submit a new version of this patch. - Marc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1621/#review4009 ----------------------------------------------------------- On Jan. 25, 2013, 3:03 p.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1621/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 3:03 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9467:84decd4c3a2d > --------------------------- > test: A test program for the new mwait implementation. > > This is a simple test program for the new mwait implemenation. It is uses > m5threads to create to threads of execution in syscall emulation mode that > interact using the mwait instruction. > > *Note* This patch was originally created by Marc Orr ([email protected]) > > > Diffs > ----- > > tests/test-progs/mwait/Makefile PRE-CREATION > tests/test-progs/mwait/mwait.c PRE-CREATION > > Diff: http://reviews.gem5.org/r/1621/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
