----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1621/#review4009 -----------------------------------------------------------
tests/test-progs/mwait/Makefile <http://reviews.gem5.org/r/1621/#comment3854> Extra space at the end of line. tests/test-progs/mwait/Makefile <http://reviews.gem5.org/r/1621/#comment3855> Are sure that pthread.o is available? tests/test-progs/mwait/Makefile <http://reviews.gem5.org/r/1621/#comment3853> Why do have Makefile in the dependency list? Had it been the 'all' target which depends on the Makefile, that would look fine. But the .o file should only depend on the .c file. tests/test-progs/mwait/mwait.c <http://reviews.gem5.org/r/1621/#comment3856> These constants depend on the the cache line size, as you explained before. I think it would be good if you reintroduce that #define you had earlier (or may be a const variable) that is named cache line size and use that in place of 10. tests/test-progs/mwait/mwait.c <http://reviews.gem5.org/r/1621/#comment3857> This argument is not in use anywhere. - Nilay Vaish On Jan. 25, 2013, 3:03 p.m., Derek Hower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1621/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 3:03 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9467:84decd4c3a2d > --------------------------- > test: A test program for the new mwait implementation. > > This is a simple test program for the new mwait implemenation. It is uses > m5threads to create to threads of execution in syscall emulation mode that > interact using the mwait instruction. > > *Note* This patch was originally created by Marc Orr ([email protected]) > > > Diffs > ----- > > tests/test-progs/mwait/Makefile PRE-CREATION > tests/test-progs/mwait/mwait.c PRE-CREATION > > Diff: http://reviews.gem5.org/r/1621/diff/ > > > Testing > ------- > > > Thanks, > > Derek Hower > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
