----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2112/#review4827 -----------------------------------------------------------
The extreme verbosity of the ruby output concerns me greatly. While the stats.txt file format is very easy to parse, it is extremely difficult to read. The generated statistics from ruby controllers are immensely valuable for debugging performance problems and they are read often by humans. I do not want to delete the ruby.stats file until the stats.txt file can provide ruby generated statistics in a similar concise format. I strongly argue against this patch begin checked in until we can fix the stats.txt format. Sorry to be so negative on this patch, but I feel pretty strongly about this. - Brad Beckmann On Dec. 6, 2013, 11:11 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2112/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 11:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9996:2e8f8f2bb7d7 > --------------------------- > stats: updates to changes to ruby > > > Diffs > ----- > > > tests/long/fs/10.linux-boot/ref/x86/linux/pc-simple-timing-ruby-MESI_CMP_directory/config.ini > bdd606534bdc > > tests/long/fs/10.linux-boot/ref/x86/linux/pc-simple-timing-ruby-MESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/stats.txt > bdd606534bdc > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/config.ini > bdd606534bdc > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_CMP_token/stats.txt > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/config.ini > bdd606534bdc > > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby-MOESI_hammer/stats.txt > bdd606534bdc > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/config.ini > bdd606534bdc > tests/quick/se/00.hello/ref/alpha/tru64/simple-timing-ruby/stats.txt > bdd606534bdc > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/config.ini > bdd606534bdc > tests/quick/se/00.hello/ref/mips/linux/simple-timing-ruby/stats.txt > bdd606534bdc > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/config.ini > bdd606534bdc > tests/quick/se/00.hello/ref/sparc/linux/simple-timing-ruby/stats.txt > bdd606534bdc > tests/quick/se/00.hello/ref/x86/linux/simple-timing-ruby/config.ini > bdd606534bdc > tests/quick/se/00.hello/ref/x86/linux/simple-timing-ruby/stats.txt > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_token/config.ini > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_CMP_token/stats.txt > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_hammer/config.ini > bdd606534bdc > > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby-MOESI_hammer/stats.txt > bdd606534bdc > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby/config.ini > bdd606534bdc > tests/quick/se/50.memtest/ref/alpha/linux/memtest-ruby/stats.txt > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/config.ini > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/stats.txt > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/config.ini > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/stats.txt > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/config.ini > bdd606534bdc > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/stats.txt > bdd606534bdc > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/config.ini > bdd606534bdc > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/stats.txt > bdd606534bdc > > Diff: http://reviews.gem5.org/r/2112/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
