On Sat, 7 Dec 2013, Brad Beckmann wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2112/#review4827
-----------------------------------------------------------
The extreme verbosity of the ruby output concerns me greatly. While the
stats.txt file format is very easy to parse, it is extremely difficult
to read. The generated statistics from ruby controllers are immensely
valuable for debugging performance problems and they are read often by
humans. I do not want to delete the ruby.stats file until the stats.txt
file can provide ruby generated statistics in a similar concise format.
I strongly argue against this patch begin checked in until we can fix
the stats.txt format.
Sorry to be so negative on this patch, but I feel pretty strongly about this.
I am open to changes. It would be good if you can provide examples. In
my opinion, readability not only a function of what you are reading but
also a function of what you are habitual of reading. With time, the
current format will also start appearing to be concise.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
