----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2148/#review4868 -----------------------------------------------------------
configs/common/FSConfig.py <http://reviews.gem5.org/r/2148/#comment4545> I'm not a massive fan of this implicit splitting. Is there no sensible way we can make this more explicit, for example by forcing the user to specify a (comma-separated) list of sizes? configs/common/FSConfig.py <http://reviews.gem5.org/r/2148/#comment4546> Implicit assumptions here as well that would be good to avoid. - Andreas Hansson On Jan. 18, 2014, 2:38 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2148/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2014, 2:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10015:ad6b02503cc7 > --------------------------- > config: allow more than 3GB of memory for x86 simulations > This patch edits the configuration files so that x86 simulations can have > more than 3GB of memory. It also corrects a bug in the MemConfig.py script. > > > Diffs > ----- > > configs/common/FSConfig.py a362694dda2d > configs/common/MemConfig.py a362694dda2d > configs/example/fs.py a362694dda2d > > Diff: http://reviews.gem5.org/r/2148/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
