----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2505/#review5527 -----------------------------------------------------------
Please take a look at 2506 as well. - Gabe Black On Nov. 23, 2014, 2:54 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2505/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 2:54 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10539:6785122e7e3b > --------------------------- > arch: Allow named constants as decode case values. > > The values in a "bitfield" or in an ExtMachInst structure member may not be a > literal value, it might select from an arbitrary collection of options. > Instead > of using the raw value of those constants in the decoder, it's easier to tell > what's going on if they can be referred to as a symbolic constant/enum. > > To support that, the ISA description language is extended slightly so that in > addition to integer literals, the case value for decode blobs can also be a > string literal. It's up to the ISA author to ensure that the string evaluates > to a legal constant value when interpretted as C++. > > > Diffs > ----- > > src/arch/isa_parser.py 1a9e235cab09e37837819876d28fbd2914a47291 > > Diff: http://reviews.gem5.org/r/2505/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
