> On Dec. 1, 2014, 9:44 p.m., Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 1991 > > <http://reviews.gem5.org/r/2505/diff/2/?file=42744#file42744line1991> > > > > update comment > > Gabe Black wrote: > I assume you mean just making it plural? The values do still have to be > constant or C++ will get angry.
yea, something like "matches any of the specified constant(s)" or "matches a member of the constant list" - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2505/#review5598 ----------------------------------------------------------- On Dec. 3, 2014, 3:56 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2505/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 3:56 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10590:1c185336bb80 > --------------------------- > arch: Allow named constants as decode case values. > > The values in a "bitfield" or in an ExtMachInst structure member may not be a > literal value, it might select from an arbitrary collection of options. > Instead > of using the raw value of those constants in the decoder, it's easier to tell > what's going on if they can be referred to as a symbolic constant/enum. > > To support that, the ISA description language is extended slightly so that in > addition to integer literals, the case value for decode blobs can also be a > string literal. It's up to the ISA author to ensure that the string evaluates > to a legal constant value when interpretted as C++. > > > Diffs > ----- > > src/arch/isa_parser.py 5962812f80fef83240fcb023806e523aa257c2fd > > Diff: http://reviews.gem5.org/r/2505/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
