----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2553/#review5642 -----------------------------------------------------------
Ship it! Look good to me. Do the regressions still pass? - Andreas Hansson On Dec. 4, 2014, 7:14 p.m., Cagdas Dirik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2553/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 7:14 p.m.) > > > Review request for Default, Andrew Bardsley, Andreas Hansson, and Ali Saidi. > > > Repository: gem5 > > > Description > ------- > > This change includes edits to Intel8254Timer to prevent counter events firing > before startup to comply with SimObject initialization call sequence. > > > Diffs > ----- > > src/dev/intel_8254_timer.hh fea29fc045ee > src/dev/intel_8254_timer.cc fea29fc045ee > src/dev/x86/i8254.hh fea29fc045ee > src/dev/x86/i8254.cc fea29fc045ee > > Diff: http://reviews.gem5.org/r/2553/diff/ > > > Testing > ------- > > > Thanks, > > Cagdas Dirik > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
