> On Dec. 5, 2014, 11:45 a.m., Andreas Hansson wrote: > > Look good to me. Do the regressions still pass? > > Cagdas Dirik wrote: > I ran the same tests as I mentioned in r/2545. Please let me know if I > need to test more. > > Cagdas Dirik wrote: > This very likely needs updates similar to r/2545 to carry the changes for > alpha and mips. I am working on an update. > > Cagdas Dirik wrote: > I have changes ready for alpha and mips, but they are on top of r/2545, > and I don't know how to reflect that diff dependency here. So may be better > to have r/2545 to be finished and submitted first. And then I will update > this one. > Also I could not convince myself yet if src/dev/x86/speaker.* needs > editing as well. It uses I8254 but it does not serialize/unserialize it, so I > am not sure if it needs a timer->startup() call. This should also give me > time to take a better look. > > Nilay Vaish wrote: > What's the status of this patch?
I saw that r/2545 is submitted now - thank you. I have updates ready for this patch. Will prepare them shortly and update here, once I run regression tests. - Cagdas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2553/#review5642 ----------------------------------------------------------- On Dec. 4, 2014, 7:14 p.m., Cagdas Dirik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2553/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 7:14 p.m.) > > > Review request for Default, Andrew Bardsley, Andreas Hansson, and Ali Saidi. > > > Repository: gem5 > > > Description > ------- > > This change includes edits to Intel8254Timer to prevent counter events firing > before startup to comply with SimObject initialization call sequence. > > > Diffs > ----- > > src/dev/intel_8254_timer.hh fea29fc045ee > src/dev/intel_8254_timer.cc fea29fc045ee > src/dev/x86/i8254.hh fea29fc045ee > src/dev/x86/i8254.cc fea29fc045ee > > Diff: http://reviews.gem5.org/r/2553/diff/ > > > Testing > ------- > > > Thanks, > > Cagdas Dirik > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
