----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2691/ -----------------------------------------------------------
(Updated May 6, 2015, 3:59 p.m.) Review request for Default. Changes ------- This is an alternative version of the patch that uses a goto to narrow the scope of the early_exit flag and reduce indentation levels. I'm not necessarily replacing the prior patch with this one; I really just want to post two alternatives, and this seemed easier than creating a whole new patch to review. You probably want to focus just on the diff between this revision and the previous one. Repository: gem5 Description ------- Changeset 10745:9b84d1b570e3 --------------------------- mem: implement x86 locked accesses in timing-mode classic cache Add LockedRMW(Read|Write)(Req|Resp) commands. In timing mode, use a combination of clearing permission bits and leaving an MSHR in place to prevent accesses & snoops from touching a locked block between the read and write parts of an locked RMW sequence. Diffs (updated) ----- src/mem/cache/cache_impl.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/cache/mshr.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/packet.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/packet.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec Diff: http://reviews.gem5.org/r/2691/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
