----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2805/#review6211 -----------------------------------------------------------
Ship it! Other than the small change below, LGTM. src/mem/ruby/network/MessageBuffer.hh (line 177) <http://reviews.gem5.org/r/2805/#comment5376> Is this necessary with auto in C++11? On second thought, it doesn't seem to be used in the patch anyway. - Jason Power On May 11, 2015, 10:22 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2805/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10862:91c1912ec60e > --------------------------- > ruby: Fix for stallAndWait bug > > It was previously possible for a stalled message to be reordered after an > incomming message. This patch ensures that any stalled message stays in its > original request order. > > > Diffs > ----- > > src/mem/ruby/network/MessageBuffer.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/MessageBuffer.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/slicc_interface/AbstractController.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/slicc_interface/AbstractController.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2805/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
