> On May 12, 2015, 9:39 p.m., Nilay Vaish wrote: > > src/mem/ruby/slicc_interface/AbstractController.cc, line 168 > > <http://reviews.gem5.org/r/2805/diff/1/?file=45063#file45063line168> > > > > You need to explain why a message buffer may get analyzed twice. I am > > guessing this is because of the other patch where in you allow for multiple > > message types in the same buffer. My guess is that it should be ok to call > > reanalyze twice as long as you empty the wait buffer.
A message buffer could be analyzed twice simply because multiple transitions within the same cycle could call reanalyzeMessages or reanalyzeAllMessages. It has nothing to do with the patch that allows for multiple message types in the same buffer. > On May 12, 2015, 9:39 p.m., Nilay Vaish wrote: > > src/mem/ruby/network/MessageBuffer.hh, line 177 > > <http://reviews.gem5.org/r/2805/diff/1/?file=45060#file45060line177> > > > > Unused typedef Thanks. Typedef removed. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2805/#review6212 ----------------------------------------------------------- On May 11, 2015, 10:22 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2805/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10862:91c1912ec60e > --------------------------- > ruby: Fix for stallAndWait bug > > It was previously possible for a stalled message to be reordered after an > incomming message. This patch ensures that any stalled message stays in its > original request order. > > > Diffs > ----- > > src/mem/ruby/network/MessageBuffer.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/MessageBuffer.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/slicc_interface/AbstractController.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/slicc_interface/AbstractController.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2805/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
