----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2805/#review6468 -----------------------------------------------------------
I think I'm ok with this change (though I agree with Nilay that this could be implemented in a much cleaner way with std::list, which can preserve order). src/mem/ruby/network/MessageBuffer.cc (line 320) <http://reviews.gem5.org/r/2805/#comment5552> I think you should use curTick(). Using clockEdge() to schedule an even for the current tick implicitly assumes that reanalyzeMessages will always be called on a clock edge so that clockEdge() returns the current tick. If reanalyzeMessages is not called on a clock edge, clockEdge() returns the first tick of the next cycle, which reintroduces delays. This is likely to reintroduce the bug (if I'm reading this correctly). src/mem/ruby/network/MessageBuffer.cc (line 336) <http://reviews.gem5.org/r/2805/#comment5553> Same as last comment. src/mem/ruby/network/MessageBuffer.cc (line 346) <http://reviews.gem5.org/r/2805/#comment5551> Since you're modifying the line, can you also fix the whitespace. - Joel Hestness On May 26, 2015, 8:03 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2805/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 8:03 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10835:e6fd9419eacf > --------------------------- > ruby: Fix for stallAndWait bug > > It was previously possible for a stalled message to be reordered after an > incomming message. This patch ensures that any stalled message stays in its > original request order. > > > Diffs > ----- > > src/mem/ruby/network/MessageBuffer.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/slicc_interface/AbstractController.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/slicc_interface/AbstractController.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2805/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
