> On May 12, 2015, 4:08 a.m., Nilay Vaish wrote: > > Again, I would like to know what behaviour is this change trying to achieve?
What more do I need to say beyond what the description already says? It allows us to overload global functions, such as those used for mapping. SLICC already supports overloading for classes. This patch just completes the overloading support. > On May 12, 2015, 4:08 a.m., Nilay Vaish wrote: > > src/mem/slicc/symbols/Transition.py, line 43 > > <http://reviews.gem5.org/r/2810/diff/1/?file=45094#file45094line43> > > > > Can you explain what this statement is doing? Please avoid adding such > > special cases. I'm not sure I follow this comment/question. First, SLICC is full of special cases. Secondly, I'm not even introducing a new special case. I'm just improving the already existing test to make sure that the needed getNextState function uses an Address as an input parameter. Please note that to support overloading, the function id is the combination of the function name and input parameters separated by underscores. - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2810/#review6139 ----------------------------------------------------------- On May 11, 2015, 10:19 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2810/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10867:5de130c7b15d > --------------------------- > slicc: enable overloading in functions not in classes > > For many years the slicc symbol table has supported overloaded functions in > external classes. This patch extends that support to functions that are not > part of classes (a.k.a. no parent). For example, this support allows slicc > to understand that mapAddressToRange is overloaded and the NodeID is an > optional parameter. > > > Diffs > ----- > > src/mem/slicc/symbols/Func.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/symbols/Transition.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/protocol/RubySlicc_ComponentMapping.sm > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/EnumDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/FuncCallExprAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/FuncDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/InPortDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/StateDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2810/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
