> On May 19, 2015, 9:15 p.m., Brad Beckmann wrote: > > Are there any more comments on this patch? > > Nilay Vaish wrote: > Overall I am fine with the patch. I think there are places where there > is no space > between the operator '+' and its operands.
I forgot to say one thing. Since I am going to insist on getNextState() being dropped altogether, it should be dropped from this patch as well. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2810/#review6353 ----------------------------------------------------------- On May 11, 2015, 10:19 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2810/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10867:5de130c7b15d > --------------------------- > slicc: enable overloading in functions not in classes > > For many years the slicc symbol table has supported overloaded functions in > external classes. This patch extends that support to functions that are not > part of classes (a.k.a. no parent). For example, this support allows slicc > to understand that mapAddressToRange is overloaded and the NodeID is an > optional parameter. > > > Diffs > ----- > > src/mem/slicc/symbols/Func.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/symbols/Transition.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/protocol/RubySlicc_ComponentMapping.sm > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/EnumDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/FuncCallExprAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/FuncDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/InPortDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/StateDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2810/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
