On Tue, 12 May 2015, Brad Beckmann wrote:
On May 12, 2015, 4:08 a.m., Nilay Vaish wrote:
Again, I would like to know what behaviour is this change trying to achieve?
What more do I need to say beyond what the description already says?
It allows us to overload global functions, such as those used for
mapping. SLICC already supports overloading for classes. This patch
just completes the overloading support.
And why do we need this support? What is it that you cannot do right now?
Give me an example of the situation where this support would be useful,
that without this support, we would not be able to do.
On May 12, 2015, 4:08 a.m., Nilay Vaish wrote:
src/mem/slicc/symbols/Transition.py, line 43
<http://reviews.gem5.org/r/2810/diff/1/?file=45094#file45094line43>
Can you explain what this statement is doing? Please avoid adding such
special cases.
I'm not sure I follow this comment/question. First, SLICC is full of
special cases. Secondly, I'm not even introducing a new special case.
I'm just improving the already existing test to make sure that the
needed getNextState function uses an Address as an input parameter.
Please note that to support overloading, the function id is the
combination of the function name and input parameters separated by
underscores.
OK, that special case would be dropped since it is not required as pointed
out in the patch on wildcard in transition statements. So, you can ignore
this particular comment.
--
Nilay
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
