----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2810/#review6503 -----------------------------------------------------------
I think all the review comments are taken care now. Any more comments? - Sooraj Puthoor On May 26, 2015, 8:09 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2810/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 8:09 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10843:8851306e9602 > --------------------------- > slicc: enable overloading in functions not in classes > > For many years the slicc symbol table has supported overloaded functions in > external classes. This patch extends that support to functions that are not > part of classes (a.k.a. no parent). For example, this support allows slicc > to understand that mapAddressToRange is overloaded and the NodeID is an > optional parameter. > > > Diffs > ----- > > src/mem/slicc/ast/InPortDeclAST.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/ast/StateDeclAST.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/symbols/Func.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/symbols/Transition.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/protocol/RubySlicc_ComponentMapping.sm > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/ast/EnumDeclAST.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/ast/FuncCallExprAST.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/ast/FuncDeclAST.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2810/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
