----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3183/#review7569 -----------------------------------------------------------
src/mem/packet_queue.hh (line 133) <http://reviews.gem5.org/r/3183/#comment6505> should also be an added @param here src/mem/packet_queue.hh (line 135) <http://reviews.gem5.org/r/3183/#comment6504> bool disable_sanity_check to comply with the style guide. please also add a space around = src/mem/packet_queue.cc (line 52) <http://reviews.gem5.org/r/3183/#comment6506> see comment from header on naming src/mem/packet_queue.cc (line 118) <http://reviews.gem5.org/r/3183/#comment6507> could swap these around, up to you - Andreas Hansson On Nov. 12, 2015, 11:01 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3183/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 11:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11189:984d2bc69eea > --------------------------- > mem: add boolean to disable PacketQueue's size sanity check > > > Diffs > ----- > > src/mem/packet_queue.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/packet_queue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3183/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
