> On Nov. 12, 2015, 3:03 p.m., Andreas Hansson wrote: > > src/mem/packet_queue.cc, line 118 > > <http://reviews.gem5.org/r/3183/diff/3/?file=51629#file51629line118> > > > > could swap these around, up to you
Fixed. Also, the style guide should be updated to reflect that parameters/arguments must explicitly use snake-case, and to remove the spacing requirements around '=' in argument/parameter lists to be Python only. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3183/#review7569 ----------------------------------------------------------- On Nov. 12, 2015, 3:54 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3183/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 3:54 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11189:dec7c958bebe > --------------------------- > mem: add boolean to disable PacketQueue's size sanity check > > > Diffs > ----- > > src/mem/packet_queue.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/packet_queue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3183/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
