> On Nov. 12, 2015, 3:03 p.m., Andreas Hansson wrote: > > src/mem/packet_queue.hh, line 135 > > <http://reviews.gem5.org/r/3183/diff/3/?file=51628#file51628line135> > > > > bool disable_sanity_check to comply with the style guide. please also > > add a space around =
Can you point out where in the style guide this is mentioned? Is there a newer style guide than this: http://gem5.org/Coding_Style ? This guide explicitly states "no space around '=' when used in parameter/argument lists, either to bind default parameter values (in Python or C++) or to bind keyword arguments (in Python)". Also, it specifices member variables must use camel-case, whereas local variables use snake-case; it doesn't mention parameters/aguments afaik. I don't mind changing it, but I think if we're going to have a style guide any new standards need to be maintained on the wiki in one location. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3183/#review7569 ----------------------------------------------------------- On Nov. 12, 2015, 3:01 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3183/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 3:01 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11189:984d2bc69eea > --------------------------- > mem: add boolean to disable PacketQueue's size sanity check > > > Diffs > ----- > > src/mem/packet_queue.hh 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/packet_queue.cc 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > > Diff: http://reviews.gem5.org/r/3183/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
