Re: [m5-dev] [PATCH 3 of 5] InOrder didnt have all it's params set to a default value, which is now required for M5 objects; Also, a # of values need to be reset to 0 (or the appropriate value) before we assume they are OK for use

[nathan binkert]

> @@ -53,6 +53,15 @@ struct InterStageStruct {
>     uint64_t nextPC;
>     InstSeqNum squashedSeqNum;
>     bool includeSquashInst;
> +
> +    InterStageStruct()
> +    {
> +        size = 0;
> +        mispredPC = nextPC = 0;
> +        squash = branchMispredict = branchTaken = false;
> +        squashedSeqNum = 0;
> +    }
> +
This is a constructor, right?  Can you use proper C++ initialization?  e.g.
InterStateStruct()
    : size(0), mispredPC(0), nextPC(0), ........
{}

The compiler can do better things when you do this.

>  InOrderDynInst::InOrderDynInst()
>     : traceData(NULL), cpu(cpu)
> -{     initVars(); }
> +{
> +    seqNum = 0;
> +    initVars();
> +}
Same proper initialization for seqNum



  Nate
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev