Good catch. I'll go through and make sure this is done throughout the model before commit...
On Mon, Mar 2, 2009 at 12:18 PM, nathan binkert <[email protected]> wrote: >> @@ -53,6 +53,15 @@ struct InterStageStruct { >> uint64_t nextPC; >> InstSeqNum squashedSeqNum; >> bool includeSquashInst; >> + >> + InterStageStruct() >> + { >> + size = 0; >> + mispredPC = nextPC = 0; >> + squash = branchMispredict = branchTaken = false; >> + squashedSeqNum = 0; >> + } >> + > This is a constructor, right? Can you use proper C++ initialization? e.g. > InterStateStruct() > : size(0), mispredPC(0), nextPC(0), ........ > {} > > The compiler can do better things when you do this. > >> InOrderDynInst::InOrderDynInst() >> : traceData(NULL), cpu(cpu) >> -{ initVars(); } >> +{ >> + seqNum = 0; >> + initVars(); >> +} > Same proper initialization for seqNum > > > > Nate > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > -- ---------- Korey L Sewell Graduate Student - PhD Candidate Computer Science & Engineering University of Michigan _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
