Hmm..... ok.. it seems like the issue only exists for builders. Which means we can do it although I don't know a way to make the non COMSTR ones produce output when VERBOSE=True. Thoughts?
Ali
pretty_scons.patch
Description: Binary data
On Nov 8, 2010, at 10:29 PM, Ali Saidi wrote:
> It's not sticky since it's not added to the sticky_vars below. Although it
> seems like our options are a bit adhoc and there is an arguments() class in
> scons that does some of this for us. RE your action command below, yes I saw
> that you can do it with an Action() however, according to the mailing list
> it's broken in SCons 2.0 or late 1.X so I'm not too excited about doing it.
> If we really wanted to we could detect the version and not do it in those
> cases, but that might be too much work.
>
> Ali
>
> On Nov 8, 2010, at 6:41 PM, Gabriel Michael Black wrote:
>
>> Oh wait, that's not an environment variable, that's a scons variable from
>> the command line. My opinion still stands since it'd be sticky and it's not
>> as nice as a -- option, but it's better than an environment variable.
>>
>> Gabe
>>
>> Quoting Gabriel Michael Black <gbl...@eecs.umich.edu>:
>>
>>> I've done this before, just a sec...
>>>
>>> (some googling)
>>>
>>> I think you have to use an Action object instead of a raw command in the
>>> Command builder. When building the Action object, the second parameter is
>>> the alternative text to output.
>>>
>>> It might look like the following:
>>>
>>> env.Command(target, source, Action("foo $TARGET $SOURCES", "FOOING
>>> $SOURCES"))
>>>
>>> The []s are probably not necessary, but that's just my opinion.
>>>
>>> It might be better to support a -v or --verbose option on the scons command
>>> line if we can. An environment variable is a little obscure, and it's
>>> likely you'll just want verbose output temporarily, not as a long term
>>> environment setting. I don't really remember whether adding command line
>>> options to the scons command line is feasible and/or advisable, so I'll
>>> defer to other people's opinions, but it seems a little more natural to me.
>>>
>>> Gabe
>>>
>>> Quoting Ali Saidi <sa...@umich.edu>:
>>>
>>>>
>>>> -----------------------------------------------------------
>>>> This is an automatically generated e-mail. To reply, visit:
>>>> http://reviews.m5sim.org/r/299/
>>>> -----------------------------------------------------------
>>>>
>>>> (Updated 2010-11-08 15:49:05.987230)
>>>>
>>>>
>>>> Review request for Default.
>>>>
>>>>
>>>> Summary (updated)
>>>> -------
>>>>
>>>> Scons: Try to make SCons output prettier.
>>>>
>>>> This change has scons print [ C], [CC], [LN], etc in front of normal
>>>> commands instead of the entire command themselves and cleans up the build
>>>> a good bit. Unfortunately, I couldn't figure out a way to get the same
>>>> behavior from env.Command() calls so they're still verbose.
>>>>
>>>> Thoughts? Like it? Hate it?
>>>>
>>>>
>>>> Diffs
>>>> -----
>>>>
>>>> SConstruct f61e079ad05e
>>>>
>>>> Diff: http://reviews.m5sim.org/r/299/diff
>>>>
>>>>
>>>> Testing
>>>> -------
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Ali
>>>>
>>>> _______________________________________________
>>>> m5-dev mailing list
>>>> m5-dev@m5sim.org
>>>> http://m5sim.org/mailman/listinfo/m5-dev
>>>>
>>>
>>>
>>> _______________________________________________
>>> m5-dev mailing list
>>> m5-dev@m5sim.org
>>> http://m5sim.org/mailman/listinfo/m5-dev
>>>
>>
>>
>> _______________________________________________
>> m5-dev mailing list
>> m5-dev@m5sim.org
>> http://m5sim.org/mailman/listinfo/m5-dev
>>
>
> _______________________________________________
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>
_______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
