----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/299/#review471 -----------------------------------------------------------
Generally I'm in favor of this, but I think two characters are too few, and the abbreviations are almost arbitrary in some places. It's great to be brief and remove clutter but it's bad to be cryptic. I'd be in favor of short but meaningful tags like [PARAMS] or [ISA] or even [SWITCH HEADER]. src/arch/isa_parser.py <http://reviews.m5sim.org/r/299/#comment693> We might not want to do this. It could be confusing whether those messages are coming from scons or the parser. - Gabe On 2010-11-09 18:59:43, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/299/ > ----------------------------------------------------------- > > (Updated 2010-11-09 18:59:43) > > > Review request for Default. > > > Summary > ------- > > Scons: Try to make SCons output prettier. > > This change has scons print [ C], [CC], [LN], etc in front of normal commands > instead of the entire command themselves and cleans up the build a good bit. > Unfortunately, I couldn't figure out a way to get the same behavior from > env.Command() calls so they're still verbose. > > Thoughts? Like it? Hate it? > > > Diffs > ----- > > SConstruct f4362ffd810f > src/SConscript f4362ffd810f > src/arch/isa_parser.py f4362ffd810f > src/cpu/SConscript f4362ffd810f > > Diff: http://reviews.m5sim.org/r/299/diff > > > Testing > ------- > > > Thanks, > > Ali > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
