On Nov 9, 2010, at 9:24 PM, Gabriel Michael Black wrote: >>> >>> src/arch/isa_parser.py<http://reviews.m5sim.org/r/299/diff/3/?file=5110#file5110line1948> >>> (Diff >>> revision 3) >>> >>> def update_if_needed(self, file, contents): >>> >>> 1948 >>> >>> print 'Generating', file >>> >>> 1948 >>> >>> print ' [GN]', file >>> >>> We might not want to do this. It could be confusing whether those messages >>> are coming from scons or the parser. >>> >>> Why is that? >> >> Nate >> > > "It could be confusing whether those messages are coming from scons or the > parser." If something blows up and I need to find why, I would be very > annoyed if I dug around in scons for a while only to discover that the very > scons like tags were actually coming from the parser. Granted in a literal > sense I'm not likely to be confused because we're having this conversation > and I'd probably remember, but still [GN] isn't particularly memorable or > mnemonic. I suppose alternatively we could use indentation. We could have one > tag for running the parser at all, and then the tags the parser outputs would > be indented a few extra spaces. That would be a good visual clue what's going > on. Feel free to propose some more verbose names, but the whole idea is to remove the verbosity. Almost everything but [CC] and [SW] else gets executed once per build. If there is an error it's going to be pretty obvious where it came from, especially with GN where it's just a simple replacement of Generating: with [GN]. Honestly, how many people do you think will be messing with the parser? It's less than 5. We've run out of ISAs at this point. The only ISAs that come to mind at the moment are PARISC and IA64. One is dead and the other might as well be.
Ali _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
