On 06/22/2016 09:56 PM, Michael Orlitzky wrote:
> On 06/22/2016 08:34 PM, Dan Douglas wrote:
>> On 06/22/2016 07:12 PM, Ulrich Mueller wrote:
>>>>>>>> On Wed, 22 Jun 2016, Dan Douglas wrote:
>>>
>>>> + [[
>>>> + ( BASH_VERSINFO[0] -ge 4 || EAPI -ge 6 ) &&
>>>> + $(declare -p "EGIT_${livevars[idx+1]}" 2>/dev/null) ==
>>>> 'declare -A'*
>>>> + ]] && ref=EGIT_${livevars[idx+1]}[\$PN]
>>>
>>> EAPI is not a number but a string, so don't use arithmetic comparison
>>> to test for it
>>
>> You mean in the future it may have non-digit values that pass the
>> `case $EAPI in ...)` at the top?
>
> Yeah, it would be perfectly legal to name the next EAPI "seven" and add
> it to the case statement at the top. Then [[ "seven" -ge 6 ]] is false.
> Oh fun, thanks. Well I just dropped the EAPI check since it was pointless anyway. https://github.com/gentoo/gentoo/pull/1723/commits/3ebc1f57378a5ed4a62232ac87a0955ccdd33a4d
signature.asc
Description: OpenPGP digital signature
