On Wed, 22 Jun 2016 18:22:38 -0500 Dan Douglas <[email protected]> wrote:
> This creates new associative arrays for each "live" variable if bash4 / > eapi6 is available. Mainly for user convenience in a bashrc as an > alternative to magic variable names. > --- > eclass/git-r3.eclass | 68 > ++++++++++++++++++++++++++++++---------------------- > 1 file changed, 39 insertions(+), 29 deletions(-) My first thought was: no, thanks, no more complexity. But after some thinking, I guess this may actually be better. It would be best if we could kill the old way but I doubt it's a good idea right now. Before giving you the final answer/review, I'm going to wait a while to see what others think. In the meantime, you could also think if this could be extended to support overrides on direct git-r3_fetch calls, i.e. when ebuild fetches multiple repos. My first thought would be to use original repo URI as the key instead of PN. Or maybe support both, i.e. PN for global override and URI for in-fetch override. One request though: don't use PN but CATEGORY/PN. -- Best regards, Michał Górny <http://dev.gentoo.org/~mgorny/>
pgpGZ3dhKQT5g.pgp
Description: OpenPGP digital signature
