And it might be best to clean up after me by cherry-picking the two 
commits that were left on PR #1361 (with GSIP-136 in their title) onto 
master.
https://github.com/NielsCharlier/geoserver/commit/c28e8ddbbbaaa19ec697210ae6da696877e9af1d
https://github.com/NielsCharlier/geoserver/commit/0219db6e784f06b533e1c9b7840751129cf72347

The current state is Niels' original draft API before Jody's review, and 
the two commits are the diff from Niels' original to GSIP-136. Again, 
sorry about that. At least we are done with that monstrous pull request.

Kind regards,
Ben.

On 18/01/16 14:39, Jody Garnett wrote:
> Niels - do you mind if I gather up the result of this email thread and
> update the proposal - or would you like to?
> On Sun, Jan 17, 2016 at 4:05 PM Ben Caradoc-Davies <b...@transient.nz> wrote:
>
>> Sorry, yes it was, be me. I mistakenly assumed that all the GSIP-136
>> changes were isolated to the last two commits of PR #1361, but the
>> addition of this interface and the implementation
>> SimpleResourceNotificationDispatcher were included in an earlier commit.
>> We will need to refactor it to match the final decision on GSIP-136.
>>
>> Kind regards,
>> Ben.
>>
>> On 18/01/16 12:55, Jody Garnett wrote:
>>> Ben I noticed ResourceNotificationDispatcher
>>> <
>> https://github.com/geoserver/geoserver/blob/master/src/platform/src/main/java/org/geoserver/platform/resource/ResourceNotificationDispatcher.java
>>>
>>> is
>>> now available on master - was that accidentally merged?
>>>
>>> --
>>> Jody Garnett
>>
>> --
>> Ben Caradoc-Davies <b...@transient.nz>
>> Director
>> Transient Software Limited <http://transient.nz/>
>> New Zealand
>>

-- 
Ben Caradoc-Davies <b...@transient.nz>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to