Changes look fine. Still +1.
--
Kevin Michael Smith
smit...@draconic.ca
On Tue, Jan 19, 2016, at 05:05 PM, Jody Garnett wrote:
> Catching email list up on sprint discussion :) This conversation has settled
> down and I will update the proposal and ask for a second review.
>
> The take home message is:
>
> - Watching resources change (on the file system or in jdbc resource store) is
> different from broadcasting the change to listeners
> - Our FileSystemWatcher should be updated/replaced with the Java 7
> FileSystemWatcher
>
>
>
>
> On Mon, 18 Jan 2016 at 09:39 Niels Charlier <ni...@scitus.be> wrote:
>> This change is fine by me, my original idea was to keep the API as
unaffected as possible and keep the dispatcher something running in
the background, optionally.
>>
>>
But - that means that the FileSystemRS also will need a
ResourceNotificationDispatcher.
>>
The FileSystemWatcher almost implements it, but it takes an extra
File argument
>>
addListener(File file, String path, ResourceListener listener)
>>
>>
Either that could be changed or a FileSystemDispatcher needs to be
wrapped around the FileSystemWatcher.
>>
>>
Regards
>>
>>
Niels
>>
>>
>> On 01/17/2016 05:39 PM, Jody Garnett
wrote:
>>> Niels - do you mind if I gather up the result of this
email thread and update the proposal - or would you like to?
>>> On Sun, Jan 17, 2016 at 4:05 PM Ben
Caradoc-Davies <b...@transient.nz>
wrote:
>>>> Sorry, yes
it was, be me. I mistakenly assumed that all the GSIP-136
>>>>
changes were isolated to the last two commits of PR #1361, but
the
>>>>
addition of this interface and the implementation
>>>>
SimpleResourceNotificationDispatcher were included in an
earlier commit.
>>>>
We will need to refactor it to match the final decision on
GSIP-136.
>>>>
>>>>
Kind regards,
>>>>
Ben.
>>>>
>>>>
On 18/01/16 12:55, Jody Garnett wrote:
>>>>
> Ben I noticed ResourceNotificationDispatcher
>>>>
>
<https://github.com/geoserver/geoserver/blob/master/src/platform/src/main/java/org/geoserver/platform/resource/ResourceNotificationDispatcher.java>
>>>>
> is
>>>>
> now available on master - was that accidentally merged?
>>>>
>
>>>>
> --
>>>>
> Jody Garnett
>>>>
>>>>
--
>>>>
Ben Caradoc-Davies <b...@transient.nz>
>>>>
Director
>>>>
Transient Software Limited <http://transient.nz/>
>>>>
New Zealand
>>> --
>>> --
>>> Jody Garnett
>>>
>>>
>>> ------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
>>> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
>>>
>>>
>>> _______________________________________________
Geoserver-devel mailing list
>>> Geoserver-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>> ------------------------------------------------------------------------------
>>
Site24x7 APM Insight: Get Deep Visibility into Application Performance
>>
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
>>
Monitor end-to-end web transactions and take corrective actions now
>>
Troubleshoot faster and improve end-user experience. Signup Now!
>> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140_______________________________________________
>>
Geoserver-devel mailing list
>> Geoserver-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
> --
> --
> Jody Garnett
> ------------------------------------------------------------------------------
> Site24x7 APM Insight: Get Deep Visibility into Application Performance
> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
> Monitor end-to-end web transactions and take corrective actions now
> Troubleshoot faster and improve end-user experience. Signup Now!
> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> _________________________________________________
> Geoserver-devel mailing list
> Geoserver-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
