Gabriel Roldán ha scritto: > Hi all, > > the proposal to extend the geotools data access interfaces to allow working > with GeoAPI Feature and FeatureType as a superset of the current API based on > SimpleFeature and SimpleFeatureType is ready for your evaluation. > > The URL is > <http://docs.codehaus.org/display/GEOTOOLS/FeatureAccess+super+class+for+DataStore> > > And feel free to raise any concern as comments in the jira tracker for it at > <http://jira.codehaus.org/browse/GEOT-1701>
Hi, here is my feedback. FeatureAccess name must be killed, it's too easy to mistake it as part of the FeatureSource, FeatureSource, FeatureLocking familiy. ComplexDataStore may not sound nice, but it's at least consistent with the other names you're coming up with. ComplexFeatureStore misses modifyFeatures. We need at least the version that takes the list of attributes and the list of values. Rationale: we have remove(filter) which is the equivalent of "delete ... " on dbms. Where is the equivalent of "update ..."? Are we giving up on efficient mass feature updates? While we're at it, it would not be bad to have the method look like modifyAttributes(AttributeDesciptor[], Expression[], filter) so that updates like "update blah set price = price * 2" could be encoded... But I'm digressing, it's probably more pain than we want to take? ComplexFeatureLocking: can we get rid of the lockFeatures(Query), unlockFeatuers(Query) methods? What are they good for? We do lock features, not attributes. (Am I missing something?) The ResourceCollection part does not make sense... you say collection is not a feature and then the code example states it's a simple feature? Moreover, why is it still extending ResourceCollection? As for the no interfaces/generify debate, my generics abilities are probably lower than yours. Can anyone come up with a counter proposal using the hybrid approach so that we can have a look at it instead of talking about vapourware? Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
