Hi Justin; thanks for the nice summary of issues.
Major feedback:
- woot!
- +1
Design decisions:
- (1) temporal interfaces (everything else is a hack), include a task to have
CQL updated to use the new temporal interfaces
- (1) update FilterFactory and FilterFactory2 anything else just makes the
library harder to use. Note we may want to merge these two prior to your work?
(There is a proposal for this already)
- (1) be strict with use of FilterFactory and FilterVisitor (if not code will
be very hard to maintain). We already tried doing the wrapping approach once
for GeoTools 2.3 and it is terrible (just finally have a replacement for WFS
compliance filter visitor last week). So TemporalFilterVisitor is not a good
idea in terms of code readability
Small feedback:
- @XmlElement (to prevent horrible switch case code appearing in the library).
> To sum up I pose a few questions.
>
> 1. How do people feel about using the gt-temporal module, and in particular
> adding it as a dependency of main
Terrible; add the classes to to gt-main, gt-api or gt-metadata as appropriate
(I don't want more core library jars - makes the library harder to use).
> 2. Do people prefer approach (1), or (2/3). Or please do present another
> option.
>
>
>
(1) Feel strongly enough on this to help; as long as you schedule the work for
a weekend (how about this weekend?).
> 3. Assuming (1) should we simply add to the FilterVisitor interface breaking
> direct implementations, or come up with subinterface or the like to capture
> the temporal methods so that we do not break client code. If we do think the
> latter is a good idea then perhaps it makes sense to do the same for filter
> factory.
>
>
>
Please no subinterface. We have always been clear on the responsibilities of
these interfaces; and if we change what standard we support then these
interfaces have the responsibility to follow suite.
Jody
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
