Attention is currently required from: laforge, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )
Change subject: sgs_iface: clean up code in function decode_mme_name ...................................................................... Patch Set 3: (2 comments) File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/24c36716_f1a10254?usp=email : PS1, Line 165: const uint8_t *mme_name_enc = TLVP_VAL_MINLEN(tp, SGSAP_IE_MME_NAME, SGS_MME_NAME_LEN); > MME name is not some random DNS domain name, but a "fully qualified […] Done File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/1eca13f9_4660fbee?usp=email : PS2, Line 178: I have a problem with alternate path: At the beginning of this function we require the contents of SGSAP_IE_MME_NAME to be at least SGS_MME_NAME_LEN bytes long. This is ensured by the if (!mme_name_enc) at the beginning. So there is no way around this. Now we want to allow also proprietary MME-name formats, but I wonder if the way we do it is effective as such a proprietary format might be anything. It might also be shorter than a normal MME-name and if this is the case, we won't reach this point. I just wanted to point this out. As it seems everything worked fine so far. Maybe those proprietary formats are all the same length as the specified MME name FQDN format. Something like "mme.osmocom.org" definitely wouldn't pass the length check above. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9aec8300f15264b68ac8e7805e93e621b12cafb2 Gerrit-Change-Number: 43237 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 08:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
