Attention is currently required from: dexter, pespin. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )
Change subject: sgs_iface: clean up code in function decode_mme_name ...................................................................... Patch Set 4: (1 comment) File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/e192a2db_b2a81dff?usp=email : PS2, Line 178: > I have a problem with alternate path: At the beginning of this function we > require the contents of S […] the questions is what such proprietary formats are, how they look like, used by whom, and why there was any attempt to support them at all. This code was merged as part of ``` commit e2bd9eb37d8160b436a5a1bffc14690321f40ae6 Author: Omar Ramadan <[email protected]> Date: Fri Apr 12 09:03:39 2019 -0700 ``` So someone had a need at some point. I would be fine with not enforcing a minimum length of 55 digits at all, and possibly printing just a warning about it (if at all). To the MSC, AFAICT it doesn't really matter. We just treat the MME name as an opaque identifier and don't ever try to parse it, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9aec8300f15264b68ac8e7805e93e621b12cafb2 Gerrit-Change-Number: 43237 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 08:51:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]>
