Attention is currently required from: laforge, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )
Change subject: sgs_iface: clean up code in function decode_mme_name ...................................................................... Patch Set 5: (3 comments) This change is ready for review. Patchset: PS5: I have revisited the patch. Now everything should be clear. File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/2092e30b_c28944a5?usp=email : PS2, Line 178: > I'm also personally fine with accepting a non-3GPP FQDN there. […] I have now looked at everything again and now everything makes sense to me. I have updated the comments so that it is easier to understand. We basically just tolerate two different domain name formats with the same domain name in it. https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/ed1bf4cf_86294609?usp=email : PS2, Line 204: OSMO_ASSERT(osmo_parse_mme_domain(&gummei, mme_fqdn) == 0); > Ah, no. Looks like a made a thinking mistake here. Let's forget about this. This path was indeed completely wrong. I just had a knot in my brain... -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9aec8300f15264b68ac8e7805e93e621b12cafb2 Gerrit-Change-Number: 43237 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 16:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
