Attention is currently required from: laforge, pespin.

dexter has posted comments on this change by dexter. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email )

Change subject: sgs_iface: clean up code in function decode_mme_name
......................................................................


Patch Set 4:

(1 comment)

File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/c/osmo-msc/+/43237/comment/d781c035_76a40063?usp=email
 :
PS2, Line 204:  OSMO_ASSERT(osmo_parse_mme_domain(&gummei, mme_fqdn) == 0);
> As it seems it gets even more problematic here: Let's assume we have called 
> decode_mme_name before w […]
Ah, no. Looks like a made a thinking mistake here. Let's forget about this.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43237?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9aec8300f15264b68ac8e7805e93e621b12cafb2
Gerrit-Change-Number: 43237
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 14 Aug 2026 09:48:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to